fix: keep precision trailing zeros for negative values - #331
Open
naveentehrpariya wants to merge 1 commit into
Open
fix: keep precision trailing zeros for negative values#331naveentehrpariya wants to merge 1 commit into
naveentehrpariya wants to merge 1 commit into
Conversation
The precision option leaves the value as a string from toPrecision
(e.g. "1.50"), but decorateResult negated it arithmetically, coercing
it back to a number and dropping the requested trailing zeros:
filesize(1500, {precision: 3}) // '1.50 kB'
filesize(-1500, {precision: 3}) // '-1.5 kB' <- precision lost
Prefix the sign for the string case instead, so a negative value keeps
the same significant digits as its positive counterpart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
precisionoption leaves the value as a string fromtoPrecision(e.g."1.50"), butdecorateResultnegated it arithmetically — coercing it back to a number and dropping the trailing zeros the option asked for:So a negative value silently renders with fewer significant digits than its positive counterpart, and the same loss shows up in
array/objectoutput.This prefixes the sign for the string case instead of negating it, so negatives keep the same digits as positives. Existing behavior is unchanged everywhere else — the number path still negates as before, and the existing
filesize(-1234567890, {precision: 2}) === '-1.2 GB'assertion still passes.Adds a regression test covering string, array and object output. Full suite green (200 passing).